Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): update testing-library monorepo (major)" #240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Sep 12, 2024

Reverts #219

This PR reverts the updates of the following @testing-library packages to resolve a dependency conflict. @testing-library/[email protected] requires react@^18.0.0, but the project is currently using react@^17.0.2. This caused an ERESOLVE dependency conflict error during npm install due to incompatible peer dependencies.

@BilalQamar95 BilalQamar95 reopened this Sep 12, 2024
@BilalQamar95 BilalQamar95 self-assigned this Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (0559426) to head (1e24406).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   91.40%   89.19%   -2.21%     
==========================================
  Files         130      142      +12     
  Lines        1710     2175     +465     
  Branches      374      443      +69     
==========================================
+ Hits         1563     1940     +377     
- Misses        138      226      +88     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant