feat: Integrate BFF calls with loader and hooks #1227
Conversation
brobro10000
force-pushed
the
hu/ent-9636-2
branch
3 times, most recently
from
3ba3978
to
b720344
Compare
brobro10000
force-pushed
the
hu/ent-9636-2
branch
from
b720344
to
790931d
Compare
brobro10000
force-pushed
the
hu/ent-9636-2
branch
from
a38205d
to
144426e
Compare
brobro10000
force-pushed
the
hu/ent-9636-2
branch
from
7e70011
to
a73b16f
Compare
| queryClient, | ||
| subscriptionsQuery, |
There was a problem hiding this comment.
nit: looks like these args need to be removed from the parent function activateOrAutoApplySubscriptionLicense, too, if no longer used (same where this parent function is called).
| return subscriptionsData; | ||
| return transformSubscriptionsData({ | ||
| customerAgreement, | ||
| subscriptionLicensesByStatus: baseLicensesByStatus, |
There was a problem hiding this comment.
Given this function doesn't really utilize subscriptionLicensesByStatus here, i.e. when not relying on the BFF data, I believe it could be omitted? It'll already fallback to baseLicensesByStatus based on the logic within the transform function, no?
brobro10000
force-pushed
the
hu/ent-9636-2
branch
from
1e97344
to
22b4459
Compare
brobro10000
force-pushed
the
hu/ent-9636-2
branch
from
22b4459
to
a02a07a
Compare
| * @returns {Function|null} The BFF query function to use for the current route, or null if no match is found. | ||
| */ | ||
| export function resolveBFFQuery(pathname, options = {}) { | ||
| // Define route patterns and their corresponding query functions |
There was a problem hiding this comment.
nit: this comment technically refers to routeToBFFQueryMap below; should it be co-located?
| course_run_url: string; | ||
| resume_course_run_url?: string; | ||
| is_revoked: boolean; | ||
| due_dates: DueDate[] |
There was a problem hiding this comment.
nit: semi-colon at the end for parity with other fields.
| const { authenticatedUser } = useContext(AppContext); | ||
| const userFirstName = authenticatedUser?.name?.split(' ').shift(); | ||
|
|
||
| const [shouldShowLicenseActivationSuccessMessage, , close] = useToggle(!!sessionStorage.getItem('shouldShowActivationSuccessMessage')); |
There was a problem hiding this comment.
Name mismatch in the session storage key, shouldShowLicenseActivationSuccessMessage is used now. Optionally consider creating a constant to re-use if it makes it less prone to mismatches?
Integrates the BFF API in dashboard related API calls related to
enterpriseCourseEnrollmentsandsubscriptions.Utilize the feature flag from the MFE config for BFF API eligibility based on the
enterpriseCustomer.uuid. Currently, only a single stage customer is enabled.Determines if the user is on the dashboard route
/:enterpriseSlugbefore making a to the BFF loader.Determines if the user is feature flagged to use the BFF API as a source of truth for
enterpriseCourseEnrollmentsandsubscriptions.If the user is not eligible to use the BFF API, fallback to the existing custom query hooks passed into
useBFF.Updates the
dashboardLoaderto conditionally use either the BFF API or the existingenterpriseCourseEnrollmentsquery.Updates the root loader to determine if the user is on the dashboard route and conditionally use either the BFF API or the existing
subscriptionsQueryPending cleanup and test updates.
For all changes
Only if submitting a visual change