Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adds catalog-info.yml for the project #393

Merged
merged 1 commit into from
May 23, 2024
Merged

chore: Adds catalog-info.yml for the project #393

merged 1 commit into from
May 23, 2024

Conversation

farhaanbukhsh
Copy link
Member

No description provided.

@farhaanbukhsh farhaanbukhsh requested a review from a team as a code owner May 22, 2024 16:14
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 22, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @farhaanbukhsh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@farhaanbukhsh
Copy link
Member Author

@feanil @arbrandes can you folks have a look?

feanil
feanil approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but then feel free to merge without another round of review.

catalog-info.yaml Outdated
Comment on lines 8 to 11
links:
- url: "https://github.com/openedx/frontend-app-gradebook"
title: "Frontend App Gradebook"
icon: "Web"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to provide a link to the code, that is done automatically in backstage.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/add-catalog-file branch from c1ef622 to 9675a6e Compare May 23, 2024 06:50
@farhaanbukhsh farhaanbukhsh merged commit c21a81e into master May 23, 2024
5 checks passed
@farhaanbukhsh farhaanbukhsh deleted the farhaan/add-catalog-file branch May 23, 2024 07:57
@openedx-webhooks
Copy link

@farhaanbukhsh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farhaanbukhsh @openedx-webhooks @feanil