Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjusted grade field validation #381

Conversation

dyudyunov
Copy link
Contributor

@dyudyunov dyudyunov commented Feb 7, 2024

Description

Added simple validation for the "Adjusted grade" field in the "Edit Grades" popup:

  • allow only a numeric value
  • define the minimum value (0)
  • checking the correctness of the entered possibleGrade value

Notes

This was already merged in nutmeg and maple, but the PR to the master branch wasn't open at that time.

The same PR was opened for the master branch #382

Steps to reproduce

  1. Go to Instructor -> Student admin -> View Gradebook
  2. Click on any user
  3. In the Adjusted grade field fill in symbols, letters, a large number

Behaviour before the fix

Entering the large number has no errors and it's possible to save the incorrect value:
image
image

Entering text/special symbols results in 500 errors for the request:
image
image

@dyudyunov dyudyunov requested a review from a team as a code owner February 7, 2024 13:24
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 7, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 7, 2024

Thanks for the pull request, @dyudyunov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @farhaanbukhsh. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (ba9fb37) to head (3565486).
Report is 5 commits behind head on open-release/quince.master.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           open-release/quince.master     #381      +/-   ##
==============================================================
+ Coverage                       94.98%   95.02%   +0.03%     
==============================================================
  Files                             140      140              
  Lines                            1356     1366      +10     
  Branches                          264      269       +5     
==============================================================
+ Hits                             1288     1298      +10     
  Misses                             60       60              
  Partials                            8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Feb 7, 2024
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@farhaanbukhsh
Copy link
Member

@mphilbrick211 I can help with review on this PR.

@mphilbrick211
Copy link

@mphilbrick211 I can help with review on this PR.

Thank you, @farhaanbukhsh!

@mphilbrick211 mphilbrick211 removed the request for review from a team July 30, 2024 20:37
@farhaanbukhsh
Copy link
Member

@mphilbrick211 I will try to review the PR against master and then come back to this.

@dyudyunov
Copy link
Contributor Author

Closed as outdated

@dyudyunov dyudyunov closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: Backlog
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants