-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Assignment and course grade fields validations (quince.master) #367
base: open-release/quince.master
Are you sure you want to change the base?
Conversation
vladislavkeblysh
commented
Oct 24, 2023
- Added min max validations to assignments grade fields
- Added validations when min value must be less than max value
Thanks for the pull request, @vladislavkeblysh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #367 +/- ##
=============================================================
Coverage ? 95.05%
=============================================================
Files ? 140
Lines ? 1375
Branches ? 274
=============================================================
Hits ? 1307
Misses ? 60
Partials ? 8 ☔ View full report in Codecov by Sentry. |
Hi @openedx/content-aurora! This is ready for review/merge after the Master is all set. |
@mphilbrick211 @arbrandes can I take this review? |
Hi @farhaanbukhsh! Please do! |
@mphilbrick211 reviewing the one against master. |