Don't revert to advanced problem editor when max_attempts is set [FC-0062]

[bradenmacdonald]

Description

There was a bug causing problem components that have max_attempts set to open in the advanced editor:

The console log said:

The Problem Could Not Be Parsed from OLX. redirecting to Advanced editor. Error: Misc Attributes asscoiated with problem, opening in advanced editor

This PR fixes the issue so that the visual editor will still be used:

Supporting information

Part of #1091

Private ref: FAL-3825

Testing instructions

1. Create a problem in a library and change the "max attempts" setting (in the "Scoring" section). Save it and close the editor.
2. Re-open the editor and note it's the advanced XML editor.
3. Check out this branch
4. The editor should change in place to become the visual editor.

[openedx-webhooks]

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (c13ab00) to head (8f29423).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files        1032     1032           
  Lines       19228    19228           
  Branches     4005     4005           
=======================================
  Hits        17828    17828           
  Misses       1338     1338           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pomegranited]

👍 for this fix, but I'm having trouble saving changes to max_attempts made from the "Scoring" UI component? This clip shows the issues with a blank problem, but the same thing happens when I edit other problem types as well. Editing max_attempts in the OLX directly saves fine.

Edit.max_attempts.mp4

• I tested this on the sandbox: https://app.tagging-preview.staging.do.opencraft.hosting/course-authoring/library/lib:OpenCraft:TL/editor/problem/lb:OpenCraft:TL:problem:ac2ff7ef-1acf-437b-b233-9c6f75129080
• I read through the code
• I checked for accessibility issues N/A
• Includes documentation N/A
• User-facing strings are extracted for translation N/A

[bradenmacdonald]

@pomegranited Thanks! I think it's because you're using the OLX editor. If you use the visual editor, it should work. Though it doesn't really matter because we have an upcoming task to disable input of "max attempts" for problems in the libraries anyways - those values should only be set at the course level.

[bradenmacdonald]

@ChrisChV Could I get a quick CC review from you on this? @pomegranited has already reviewed and it's on the sandbox.