-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0059] refactor: Change lib v2 code to TS #1124
[FC-0059] refactor: Change lib v2 code to TS #1124
Conversation
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
5c6ac20
to
9694943
Compare
86f9371
to
f0ea105
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
+ Coverage 92.67% 92.72% +0.04%
==========================================
Files 696 698 +2
Lines 12392 12434 +42
Branches 2714 2711 -3
==========================================
+ Hits 11484 11529 +45
+ Misses 876 874 -2
+ Partials 32 31 -1 ☔ View full report in Codecov by Sentry. |
Note there is a bug that linting for .ts[x] files is not happening properly; I'm fixing it in #1129 but please manually make this change and run |
f0ea105
to
5d4c369
Compare
a72713e
to
05eda0a
Compare
@yusuf-musleh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR swaps back the new changes related to v2/legacy Libraries from
js -> ts
andjsx -> tsx
. They were initially removed from #1050 as it was merged before #1052 was completed.It's based off #1117 as further changes were made there.
Supporting information
Testing instructions
Make sure linting/typing checking passes and confirm that its is still functional. You can follow the testing steps in #1050
Private-ref: FAL-3751