Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue-1018 remove reference to edX user\nIn configure wiki opera… #1021

Merged
merged 2 commits into from
May 21, 2024

Conversation

bszabo
Copy link
Contributor

@bszabo bszabo commented May 20, 2024

Description

This PR corresponds to [issue 1018](#1018 Pages and Resources page - edX reference needs to be removed).

The fix entails no more than rewording a modal dialog box message. See the linked issue for a description of why the change is needed, and how to test.

@bszabo bszabo requested a review from a team as a code owner May 20, 2024 20:45
plugins/course-apps/wiki/messages.js Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (f34157e) to head (d963a38).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1021   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         708      708           
  Lines       12505    12505           
  Branches     2721     2726    +5     
=======================================
  Hits        11542    11542           
  Misses        926      926           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bszabo bszabo merged commit 54003af into master May 21, 2024
6 checks passed
@bszabo bszabo deleted the bszabo/issue-1018-edX-reference branch May 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages and Resources page - edX reference needs to be removed
2 participants