Update all edx-platform REST endpoints to support JWT Auth #34152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman2013
changed the title
farhan
requested changes
Feb 7, 2024
feanil
approved these changes
Feb 7, 2024
feanil
requested changes
Feb 7, 2024
| @@ -1146,6 +1146,7 @@ class ReplaceUsernamesView(APIView): | |||
|
|
|||
| """ | |||
|
|
|||
| authentication_classes = (JwtAuthentication,) | |||
There was a problem hiding this comment.
@salman2013 why was this added back in? It looks like there was a mismatch of response codes for a test. 403 vs 401. I think the more correct thing to do is to update the test in this case. We saw this issue here as well.
|
@feanil I have fixed the above mention things, i believe its good to merge now. thanks |
feanil
approved these changes
Feb 13, 2024
39 tasks
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The default DRF Auth classes were recently updated to allow for both JWT and Session auth by default. Any endpoint that overrides the AUTHENTICATION_CLASSES but has just session, just JWT or just both of those should be updated to remove the override.
Ticket: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=39035029