Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make jwt decode fucntion generic #354

Merged
merged 2 commits into from
Sep 19, 2023
Merged

feat: make jwt decode fucntion generic #354

merged 2 commits into from
Sep 19, 2023

Conversation

mumarkhan999
Copy link
Member

@mumarkhan999 mumarkhan999 commented Jun 16, 2023 •
edited
Loading

Related ticket

Related PR

Tasks

  • Make the verify signature functionality generic
  • Add flags for key set so that symmetric and asymmetric can be added as per demand

@mumarkhan999 mumarkhan999 force-pushed the umar/make-verify-signature-method-generic branch 4 times, most recently from 0842c78 to 38c795d Compare June 16, 2023 16:28
@mumarkhan999 mumarkhan999 mentioned this pull request Jun 16, 2023
Merged
6 tasks
@mumarkhan999 mumarkhan999 force-pushed the umar/make-verify-signature-method-generic branch from 38c795d to 8ef7018 Compare June 19, 2023 08:47
@mumarkhan999 mumarkhan999 force-pushed the umar/make-verify-signature-method-generic branch 3 times, most recently from 2ae6055 to 665c5f9 Compare June 27, 2023 13:46
@mumarkhan999 mumarkhan999 force-pushed the umar/make-verify-signature-method-generic branch from 665c5f9 to 3d6bad0 Compare July 5, 2023 12:20
@mumarkhan999 mumarkhan999 force-pushed the umar/make-verify-signature-method-generic branch 2 times, most recently from c277d72 to ef4374b Compare July 14, 2023 15:00
@timmc-edx
Copy link
Contributor

I see that you requested another review, but I still have some outstanding comments. Not sure if you saw those?

@mumarkhan999 mumarkhan999 force-pushed the umar/make-verify-signature-method-generic branch 3 times, most recently from 3ee378a to 4b6d0aa Compare September 7, 2023 09:27
@mumarkhan999
Copy link
Member Author

I see that you requested another review, but I still have some outstanding comments. Not sure if you saw those?

[Inform] Apologies for the late reply. I was busy with pymemcache and dot related tasks.

Yeah. I think I overlooked one comment at that time.

@mumarkhan999 mumarkhan999 force-pushed the umar/make-verify-signature-method-generic branch 5 times, most recently from 163b0d1 to f1a939b Compare September 11, 2023 10:30
timmc-edx
timmc-edx reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things remaining, one just a suggestion.

edx_rest_framework_extensions/auth/jwt/decoder.py Outdated Show resolved Hide resolved
edx_rest_framework_extensions/auth/jwt/decoder.py Outdated Show resolved Hide resolved
@mumarkhan999 mumarkhan999 force-pushed the umar/make-verify-signature-method-generic branch from f1a939b to 5c4d0e2 Compare September 18, 2023 14:08
@mumarkhan999 mumarkhan999 merged commit 4d04892 into master Sep 19, 2023
7 checks passed
@mumarkhan999 mumarkhan999 deleted the umar/make-verify-signature-method-generic branch September 19, 2023 08:27
@mumarkhan999 mumarkhan999 mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mumarkhan999 @timmc-edx