fix: fetch superset info from oauth

[Ian2012]

Description

This PR is an reimplementation of #40

This PR updates the oauth implementation to get a JWT to get the user information.

Have in mind that edx-platform doesn't store the fields first name and last name, that's why we need to provide the name base on the full name field. In the screenshot below, the user Cristhian G was logged in with the new implementation.

Also, the current implementation doesn't update the name after following logins.

This PR:

• Fixes Superset: Fetch superuser/staff status from OAuth openedx/openedx-aspects#42
• Resolves Bug: SSO'd users have no name in Superset #11

[openedx-webhooks]

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[mariajgrimaldi]

Since we just need to modify the add_to_headers utility method, I think we could use the add_to_body and add_to_uri that authlib implements. Don't you think?

[mariajgrimaldi]

does user_profile always have the family_name and name entries?

[mariajgrimaldi]

I think we have it backward:

        'name': name,
        'family_name': user.last_name,
        'given_name': user.first_name,
        'administrator': user.is_staff,
        'superuser': user.is_superuser,

From: https://github.com/openedx/edx-platform/blob/master/openedx/core/djangoapps/oauth_dispatch/jwt.py#L265

[mariajgrimaldi]

I tested this and it's working as expected. Just one quick comment, the first name and last name are recorded after registering, if the user already exists, then it's not saved again. I didn't know that. Maybe there's a configuration for updating existing users -- maybe it's not even needed since this project is brand new.

[pomegranited]

This is looking fantastic, and really close to being done! Great work @Ian2012 and @mariajgrimaldi , this is so much cleaner.

Please see comments inline.

[mariajgrimaldi]

can we run isort?

[Ian2012]

done

[mariajgrimaldi]

I tested this deployed in one of our installations, and it's working nicely! Thank you for the improvement 🥳

[pomegranited]

As noted above, we don't need this UserAccess tuple (or the namedtuple import) anymore:

Suggested change

	UserAccess = namedtuple(
	"UserAccess", ["username", "is_superuser", "is_staff"]
	)

[pomegranited]

👍 This works perfectly @Ian2012 ! Couple of minor nits noted below, but it's good to merge when they're resolved.

• I tested this on a fresh Tutor dev deployment.
• I read through the code
• I checked for accessibility issues N/A
• Includes documentation N/A

[Ian2012]

@pomegranited thanks for the review, it's corrected now

[openedx-webhooks]

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.