Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: add ability to filter by pipeline id/ver #9

Merged

Conversation

HumairAK
Copy link

Copy link

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-9
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-9
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-9
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-9
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-9
MLMD Server: quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-9
MLMD Envoy Proxy: quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-9
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-9

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-9.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-9
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-9"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-9"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-9"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-9"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-9"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-9"
    envoy:
      image: "quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-9"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-9"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/9/head
git checkout -b pullrequest db5b90c662668968f528ece7748c67870a6e99b4
oc apply -f dspa.pr-9.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link
Author

example of request in postman:
image

@HumairAK HumairAK merged commit d76c6b7 into opendatahub-io:master Jan 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants