Upgrade go.mod package versions #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaniHaripriya
force-pushed
the
RHOAIENG-7310-New-CVE-Fix
branch
from
f9df218
to
3be7f77
Compare
VaniHaripriya
force-pushed
the
RHOAIENG-7310-New-CVE-Fix
branch
from
3be7f77
to
8399a2f
Compare
gmfrasca
reviewed
Jul 16, 2024
Comment on lines
+153
to
+154
| golang.org/x/net v0.17.0 => golang.org/x/net v0.23.0 | ||
| golang.org/x/net v0.21.0 => golang.org/x/net v0.23.0 |
There was a problem hiding this comment.
at some point we should figure out why we're requiring v0.17.0 and v0.21.0 just to replace with v0.23.0
There was a problem hiding this comment.
+1, these could be combined into one statement replacing 0.17.0 with 0.23.0.
There was a problem hiding this comment.
snyk created a CVE for 0.21.0 version, when I added only one statement to replace 0.17.0 with 0.23.0.
gmfrasca
approved these changes
Jul 25, 2024
|
/hold, investigating backend integration test failure |
|
/unhold, lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Resolves RHOAIENG-7309
Implemented fixes on my fork and imported in my personal snyk account and made sure CVEs are eliminated. Also updated the license CSVs.
Checklist: