-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support environment variables as parameter #704
Conversation
Skipping CI for Draft Pull Request. |
5c08784
to
78f6c66
Compare
78f6c66
to
74ccb2e
Compare
/verified
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Break down the solution for #RHOAIENG-10212 into smaller PRs to facilitate review.
Description of your changes:
CLEANUP
flag allows for optional resource cleanup before the tests. Useful while retrying the test in the OpenShift environment. The final cleanup solution will be discussed in other PR.K8SAPISERVERHOST
variable provides more flexibility, enabling it to be set via a command line argument, rather than being hardcoded within the test functions."DSPA_NAME
andDSPA_EXTERNAL_NAME
as redundant variables, simplifying namespace handling by directly usingDSPA_NAMESPACE
andDSPA_EXTERNAL_NAMESPACE
. This removes unnecessary duplication.kubectl whoami --show-server
forK8SAPISERVERHOST
in the run_tests and run_tests_dspa_external_connections functions. This allows the user to defineK8SAPISERVERHOST
explicitly via command line arguments, offering better control over the testing environment, especially for air-gapped setups.DSPA_NAMESPACE
andDSPA_EXTERNAL_NAMESPACE
during the resource cleanup process. Ensures that all test-related namespaces are properly cleaned up.run_kind_tests
tosetup_kind_requirements
andrun_rhoai_tests
tosetup_rhoai_requirements
. This better reflects their functionality as preparation steps rather than test execution steps. Testing is now decoupled from resource setup.--cleanup, --k8s-api-server-host, --dspa-namespace, and --dspa-path
. This allows users to customize their test environments more dynamically when running the script.Testing instructions
Checklist