Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore empty cabundle fields. #582

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Mar 5, 2024

odh-trusted-ca-bundle can have empty ca-bundle fields, we need to account for this, and ignore them if these are found, for consistency we treat user provided ca bundles the same way.

@openshift-ci openshift-ci bot requested review from DharmitD and rimolive March 5, 2024 19:04
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-582
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/582/head
git checkout -b pullrequest a6367dc0755024ed5a171cc71def4b25691be2ea
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-582"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK HumairAK merged commit 48c5cdd into opendatahub-io:v1.6.x Mar 5, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants