-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating v2 manifests to utilize DSPO namePrefix #405
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/405/head
git checkout -b pullrequest 1e26fd0c29a73025b39ae361742dd42d59c6fce6
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-405" More instructions here on how to deploy and test a Data Science Pipelines Application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gmfrasca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves #378
Description of your changes:
Updated names of v2 manifests to remove mentions of Kfp, and utlize the
data-science-pipelines-operator-
namePrefix.Updated
serviceAccountname
toserviceAccountName
based on an error prompting to do so, while deploying v2.Testing instructions
deployed a v2 instance using
make v2deploy
to make sure all resources came up with thedata-science-pipelines-operator-
prefix correctly.Checklist