Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Upgrade testing workflow #296

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add Upgrade testing workflow #296

merged 1 commit into from
Sep 13, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Aug 30, 2023

The issue resolved by this Pull Request:

Resolves #216

Description of your changes:

  • This GH workflow sets up a kind cluster, installs OLM, deploys the OpenDataHub operator, deploys DSPO using a KfDef pointing to the most recently released branch specified via the GH action input. It further spins up a DSPA instance.
  • The action upgrades DSPO to point to a candidate version, specified in the action input, and spins up a DSPA instance in a separate namespace.
  • For now, we've set the most recently released branch to be an input just to be able to run and test this workflow out once merged, but we'll eventually set it to be the main branch of opendatahub/data-science-pipelines-operator repository in the KfDef.
  • Specific upgrade testing checks to ensure that the upgrade went smoothly will be covered in a separate PR.

Testing instructions

Find a successful workflow run on my fork of the DSPO respository with this same set of configs here, tested out the workflow run multiple times to ensure there aren't any flaky successes:
https://github.com/DharmitD/data-science-pipelines-operator/actions/workflows/upgrade-test.yml

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

.github/workflows/upgrade-test.yml Outdated Show resolved Hide resolved
.github/workflows/upgrade-test.yml Outdated Show resolved Hide resolved
.github/workflows/upgrade-test.yml Outdated Show resolved Hide resolved
.github/workflows/upgrade-test.yml Outdated Show resolved Hide resolved
@DharmitD
Copy link
Member Author

DharmitD commented Sep 13, 2023

Latest successful run on my fork with these changes: https://github.com/DharmitD/data-science-pipelines-operator/actions/runs/6113169351/job/16592134955

@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6366229 into opendatahub-io:main Sep 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate the DSP Upgrade testing process
5 participants