Fix return value of get_dspo_image

opendatahub-io · Sep 18, 2024 · fe3c578 · fe3c578
1 parent 67e9e1a
commit fe3c578
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/.github/scripts/tests/tests.sh b/.github/scripts/tests/tests.sh
@@ -28,13 +28,11 @@ RESOURCES_DIR_CRD="${GIT_WORKSPACE}/.github/resources"
 OPENDATAHUB_NAMESPACE="opendatahub"
 RESOURCES_DIR_PYPI="${GIT_WORKSPACE}/.github/resources/pypiserver/base"
 
-# Functions
 get_dspo_image() {
   if [ "$REGISTRY_ADDRESS" = "" ]; then
       echo "REGISTRY_ADDRESS variable not defined." && exit 1
   fi
   local image="${REGISTRY_ADDRESS}/data-science-pipelines-operator"
-  echo "Using $image for DSPO image"
   echo $image
 }
 
@@ -47,10 +45,10 @@ apply_crd() {
 }
 
 build_image() {
+  IMG=$(get_dspo_image)
   echo "---------------------------------"
-  echo "Build image"
+  echo "Building image: $IMG"
   echo "---------------------------------"
-  IMG=$(get_dspo_image)
   ( cd $GIT_WORKSPACE && make podman-build -e IMG="$IMG" )
 }
 
@@ -69,10 +67,10 @@ deploy_argo_lite() {
 }
 
 deploy_dspo() {
+  IMG=$(get_dspo_image)
   echo "---------------------------------"
-  echo "Deploy DSPO"
+  echo "Deploying DSPO: $IMG"
   echo "---------------------------------"
-  IMG=$(get_dspo_image)
   ( cd $GIT_WORKSPACE && make podman-push -e IMG="$IMG" )
   ( cd $GIT_WORKSPACE && make deploy-kind -e IMG="$IMG" )
 }