Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gNOI.bgp.proto #214

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update gNOI.bgp.proto #214

wants to merge 3 commits into from

Commits on Sep 27, 2024

  1. Update gNOI.bgp.proto 

    Current gNOI.BGP proto lacks guidance on how the ClearBGPNeighborRequest must be handled. As per RFC
    @sachendras
    sachendras authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    fc24c20 View commit details
    Browse the repository at this point in the history

  2. Update gNOI.bgp.proto 

    Current gNOI.BGP proto lacks guidance on how the ClearBGPNeighborRequest.Hard must be handled. As per RFC4486, code6 subcode 4,
```If a BGP speaker decides to administratively reset the peering with a neighbor, then the speaker SHOULD send a NOTIFICATION message with the Error Code Cease and the Error Subcode "Administrative Reset".``` which basically leaves implementations to make a choice if they should "reset TCP connection" and "Flush all routes OR not Flush all routes". Hence in rfc8538#section-3.2 for GR a new subcode 9 called `HARD RESET` was introduced to clear such ambiguities so the GR process can be handled more predictively.
Having said that, the gNOI.ClearBGPNeighborRequest API must also have 2 options for reseting a TCP connection to match the RFC. The `GRACEFUL` option introduced in this pull expects sending subcode 4 and the existing `HARD` option expects sending subcode 9 so the GR behavior can be accurately handled.
    @sachendras
    sachendras authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0ee80a1 View commit details
    Browse the repository at this point in the history

  3. Update gNOIbgp.proto 

    Update to be more accurate and match the RFC requirements in rfc8538#section-3.1 for subcode9.
    @sachendras
    sachendras authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a5ab33f View commit details
    Browse the repository at this point in the history