Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pending to bill relation types #23

Closed
wants to merge 1 commit into from
Closed

add pending to bill relation types #23

wants to merge 1 commit into from

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Jan 23, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.72% when pulling 01b1a69 on fgregg:patch-3 into e2870ce on opencivicdata:master.

@paultag
Copy link
Contributor

paultag commented Apr 1, 2015

Hurm.

So, what are we to have Pupa to do here?

@fgregg
Copy link
Contributor Author

fgregg commented Apr 1, 2015

We need a post-write hook for rewriting these flags opencivicdata/pupa#86

@fgregg fgregg mentioned this pull request Apr 7, 2015
Merged
@jpmckinney
Copy link
Member

Why set a relation type at all until one is known? Could you not leave it blank?

@fgregg
Copy link
Contributor Author

fgregg commented Aug 27, 2015

@jpmckinney good question.

@jpmckinney
Copy link
Member

Closing as the proposed relation type seems to represent an internal software state, not a fact about the real world. Can re-open if not the case.

@jpmckinney jpmckinney closed this Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgregg @coveralls @paultag @jpmckinney