Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Philippines ocd id update #392

Merged

Conversation

GoogleCivics-Kantar
Copy link
Contributor

HI @jpmckinney

We have made the following changes for Philippines.

  1. Added Alias.csv file where Maguindanao's 1st, Maguindanao's 2nd districts are renamed to Maguindanao del Norte, Maguindanao del Sur respectively.
  2. We have added a new district (South Cotabato's 3rd) in congressional_district.csv file.
  3. We have added valid-through dates to Maguindanao's 1st, Maguindanao's 2nd districts.
  4. Also we have added above changes in country-ph.csv

@jpmckinney
Copy link
Member

For the Maguindanao renaming, shouldn't the Norte and Sur be validFrom 2025-05? As-is, it means all of 1st, 2nd, Norte and Sur are valid until then.

@GoogleCivics-Kantar
Copy link
Contributor Author

For the Maguindanao renaming, shouldn't the Norte and Sur be validFrom 2025-05? As-is, it means all of 1st, 2nd, Norte and Sur are valid until then.

@jpmckinney we have made the suggested change

@jpmckinney
Copy link
Member

jpmckinney commented Sep 17, 2024

It looks like there were more changes to districts, and the Manguidanao changes might have already been completed? See Redistricting on Wikipedia: https://en.m.wikipedia.org/wiki/2025_Philippine_House_of_Representatives_elections

An official source would be good to verify against.

ocd-division/country:ph/cd:zamboanga_sibugay_2nd,Zamboanga Sibugay's 2nd,,
ocd-division/country:ph/cd:south_cotabato_3rd,South Cotabato's 3rd,2025-05,
ocd-division/country:ph/cd:maguindanao_del_norte,Maguindanao del Norte,2025-05,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Maguindanao del Norte and del Sur have been represented in the House of Representatives since 2022. I would expect validFrom to be set to 2022.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @azuser we have updated valid from date of Maguindanao del Norte and del Sur to 2022.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azuser we have updated the full valid from date for Maguindanao del Norte and Maguindanao del Sur
and full valid through dates for Maguindanao's 1st and Maguindanao's 2nd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please arrange the list in alphabetical order.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please adjust the order of
ocd-division/country:ph/cd:biñan,Biñan's at-large,,
ocd-division/country:ph/cd:biliran,Biliran's at-large,,

identifiers/country-ph/aliases.csv Outdated Show resolved Hide resolved
@CivicsAbhishek
Copy link

It looks like there were more changes to districts, and the Manguidanao changes might have already been completed? See Redistricting on Wikipedia: https://en.m.wikipedia.org/wiki/2025_Philippine_House_of_Representatives_elections

An official source would be good to verify against.

@jpmckinney In the 18th and 19th Congress, bills were proposed and passed for redistricting and establishing new provinces for Maguindanao del Norte and Maguindanao del Sur, as well as creating a new district for South Cotabato's 3rd congressional district. These changes impact national representation, while the reapportionment of Makati's 2nd congressional district and Taguig/Pateros's 1st and 2nd districts do not affect national representation, as it pertains to the local-level redistribution of barangays. Agusan del Norte's changes has been already done.

In 19th Congress, bills for redistricting have been proposed but were not passed.

Maguindanao's 1st and 2nd congressional districts were two of the congressional districts in the province of Maguindanao, Philippines till Sept 2022. In 2022, a plebiscite was held to divide Maguindanao and create the provinces of Maguindanao del Norte and Maguindanao del Sur, which involved extending the districts by incorporating cities. As a result of this reapportionment, Maguindanao's 1st and 2nd districts were dissolved.

@GoogleCivics-Kantar
Copy link
Contributor Author

@azuser we have made the following changes

  1. We have added two new districts: Agusan del Norte's and Butuan in congressional_district.csv file.
  2. We have added valid-through dates to Agusan del Norte's 1st, Agusan del Norte's 2nd districts.
  3. Also, we have made the above changes in country-ph.csv.

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, confirming that

General Santos mentioned on Wikipedia already exists in this file (and is already active).

https://en.m.wikipedia.org/wiki/2025_Philippine_House_of_Representatives_elections indicates that there is indeed 1 "New districts from redistricting laws from previous Congress" which matches this change.

@jpmckinney jpmckinney merged commit 0fc8bdf into opencivicdata:master Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants