Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT electoral district changes 2023-11-30 #391

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

zikowang
Copy link
Contributor

@zikowang zikowang commented Sep 2, 2024

This PR adds the latest changes for Lithuania.

  • added validFrom and validThrough columns
  • added 4 new electoral districts
  • invalidated 4 old electoral districts
  • added a README with sources

Copy link
Contributor

@jloutsenhizer jloutsenhizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verfiied the 4 added districts show up int he provided source and the 4 removed districts do not.

One note, it's a bit odd we have the country-level ocd ID in the electoral_districts.csv file. Ideally that'd be in its own file. However, that's not caused by this change, so we can clean that up later.

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpmckinney jpmckinney merged commit 6a0c3ba into opencivicdata:master Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants