-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redistricting, state courts, and territories updates #321
Conversation
Add Washington Court of Appeals subdivisions
New districts from 2020 redistricting, territorial districts
washington court of appeals division/district hierarchy
Updated MA senate districts and validto/from dates for redistricting changes
New districts added from redistricting; validFrom dates for those and validTo dates for expiring districts; add various missing NH districts; add territory districts
removed duplicate for "Maryland State Legislative district 30 (obsolete)"
removed duplicate MD 31 obsolete
removed duplicate obsoletes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good, just have a few minor tweaks. Also, curious about the 'validTo' header, shouldn't it be 'validThrough' according to the docs @jloutsenhizer?
ocd-division/country:us/state:ma/sldu:berkshire_hampshire_franklin_and_hampden,"Massachusetts Berkshire, Hampshire, Franklin & Hampden district",,2023-01-02 | ||
ocd-division/country:us/state:ma/sldu:berkshire_hampden_franklin_and_hampshire,"Massachusetts Berkshire, Hampden, Franklin, and Hampshire district",2023-01-03, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like in MA the effective date state legislators take office is "the first Wednesday in January" according to the MA SoS. So the validFrom date should be 1/4/23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ballotpedia can you take a look into this?
ocd-division/country:us/state:nc/sldu:28,North Carolina State Senate district 28,, | ||
ocd-division/country:us/state:nc/sldu:29,North Carolina State Senate district 29,, | ||
ocd-division/country:us/state:nc/sldu:30,North Carolina State Senate district 30,, | ||
ocd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be hyphenated as /sldu:chittenden-central
instead of underscored /sldu:chittenden_central
to reflect the descriptions in this redistricting doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't look like the comment preview is showing the right lines, but referring to lines 1785-1787
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ballotpedia can you address this comment? I don't have a strong opinion either way
Would be great to get this merged in, so we can get the final OCD identifiers stabilized for the updated districts |
It looks like districts were updated for the ND and SD house, but not for the senate (the districts are the same for the house and senate). The following entries are thus missing:
|
Thanks for flagging this. We double-checked some sources but do not believe the North Dakota and South Dakota senates split their districts in this way. Here are the 2023 Senate membership lists for each chamber, which do not indicate such splits: |
@ballotpedia Thanks for double checking this! The sources I'm getting these from are: North Dakota: https://ndlegis.gov/downloads/redistricting-2021/finalshape1282021.zip South Dakota: The Find My Legislators 2021 adopted map: https://sdlegislature.gov/Legislators/Find (District 26A/B and 28A/B are visible). I am not sure why there is mismatch with the legislator rooster. |
Thank you -- sorry for the delay, but just an update that we are looking more closely into this |
We have confirmed that only the lower chambers (House) for both of these states have these separate subdivisions. |
@ballotpedia Thanks for confirming! |
@nuttingd1 you're right about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me. @ballotpedia can you take a look into the issues raised by @nuttingd1
ocd-division/country:us/state:nc/sldu:28,North Carolina State Senate district 28,, | ||
ocd-division/country:us/state:nc/sldu:29,North Carolina State Senate district 29,, | ||
ocd-division/country:us/state:nc/sldu:30,North Carolina State Senate district 30,, | ||
ocd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ballotpedia can you address this comment? I don't have a strong opinion either way
ocd-division/country:us/state:ma/sldu:berkshire_hampshire_franklin_and_hampden,"Massachusetts Berkshire, Hampshire, Franklin & Hampden district",,2023-01-02 | ||
ocd-division/country:us/state:ma/sldu:berkshire_hampden_franklin_and_hampshire,"Massachusetts Berkshire, Hampden, Franklin, and Hampshire district",2023-01-03, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ballotpedia can you take a look into this?
Hi @jloutsenhizer , I have pushed a change that should take care of the issues mentioned above in the us_sldu.csv file.
I also ran the compile script and tests. Please let me know if there is anything else! |
@ballotpedia can you also change the "validTo" header in the us_sldl.csv file to "validThrough" and run the compile script again? |
@nuttingd1 done! How's it look now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ballotpedia these changes look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but the person from our group who possibly had merge rights has left. @jloutsenhizer?
Thanks everyone for contributing to reviewing this. Merged. |
combines the following pull requests and the requested changes to those:
#314 (us_state_courts.csv)
#313 (us_sldu.csv)
#312 (us_sldl.csv)