Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redistricting, state courts, and territories updates #321

Merged
merged 12 commits into from
Feb 23, 2023

Conversation

ballotpedia
Copy link
Contributor

combines the following pull requests and the requested changes to those:
#314 (us_state_courts.csv)

#313 (us_sldu.csv)

#312 (us_sldl.csv)

Ballotpedia and others added 10 commits October 18, 2022 10:11
Add Washington Court of Appeals subdivisions
New districts from 2020 redistricting, territorial districts
washington court of appeals division/district hierarchy
Updated MA senate districts and validto/from dates for redistricting changes
New districts added from redistricting; validFrom dates for those and validTo dates for expiring districts; add various missing NH districts; add territory districts
removed duplicate for "Maryland State Legislative district 30 (obsolete)"
removed duplicate MD 31 obsolete
removed duplicate obsoletes
Copy link
Contributor

@nuttingd1 nuttingd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks good, just have a few minor tweaks. Also, curious about the 'validTo' header, shouldn't it be 'validThrough' according to the docs @jloutsenhizer?

Comment on lines 779 to 780
ocd-division/country:us/state:ma/sldu:berkshire_hampshire_franklin_and_hampden,"Massachusetts Berkshire, Hampshire, Franklin & Hampden district",,2023-01-02
ocd-division/country:us/state:ma/sldu:berkshire_hampden_franklin_and_hampshire,"Massachusetts Berkshire, Hampden, Franklin, and Hampshire district",2023-01-03,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like in MA the effective date state legislators take office is "the first Wednesday in January" according to the MA SoS. So the validFrom date should be 1/4/23

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ballotpedia can you take a look into this?

ocd-division/country:us/state:nc/sldu:28,North Carolina State Senate district 28,,
ocd-division/country:us/state:nc/sldu:29,North Carolina State Senate district 29,,
ocd-division/country:us/state:nc/sldu:30,North Carolina State Senate district 30,,
ocd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be hyphenated as /sldu:chittenden-central instead of underscored /sldu:chittenden_central to reflect the descriptions in this redistricting doc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like the comment preview is showing the right lines, but referring to lines 1785-1787

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ballotpedia can you address this comment? I don't have a strong opinion either way

@MiniCodeMonkey
Copy link
Contributor

Would be great to get this merged in, so we can get the final OCD identifiers stabilized for the updated districts

@MiniCodeMonkey
Copy link
Contributor

It looks like districts were updated for the ND and SD house, but not for the senate (the districts are the same for the house and senate).

The following entries are thus missing:

ocd-division/country:us/state:nd/sldu:4a,North Dakota State Senate district 4A
ocd-division/country:us/state:nd/sldu:4b,North Dakota State Senate district 4B
ocd-division/country:us/state:nd/sldu:9a,North Dakota State Senate district 9A
ocd-division/country:us/state:nd/sldu:9b,North Dakota State Senate district 9B

ocd-division/country:us/state:sd/sldu:26a,South Dakota State Senate district 26A
ocd-division/country:us/state:sd/sldu:26b,South Dakota State Senate district 26B
ocd-division/country:us/state:sd/sldu:28a,South Dakota State Senate district 28A
ocd-division/country:us/state:sd/sldu:28b,South Dakota State Senate district 28B

@ballotpedia
Copy link
Contributor Author

It looks like districts were updated for the ND and SD house, but not for the senate (the districts are the same for the house and senate).

The following entries are thus missing:

ocd-division/country:us/state:nd/sldu:4a,North Dakota State Senate district 4A
ocd-division/country:us/state:nd/sldu:4b,North Dakota State Senate district 4B
ocd-division/country:us/state:nd/sldu:9a,North Dakota State Senate district 9A
ocd-division/country:us/state:nd/sldu:9b,North Dakota State Senate district 9B

ocd-division/country:us/state:sd/sldu:26a,South Dakota State Senate district 26A
ocd-division/country:us/state:sd/sldu:26b,South Dakota State Senate district 26B
ocd-division/country:us/state:sd/sldu:28a,South Dakota State Senate district 28A
ocd-division/country:us/state:sd/sldu:28b,South Dakota State Senate district 28B

Thanks for flagging this. We double-checked some sources but do not believe the North Dakota and South Dakota senates split their districts in this way. Here are the 2023 Senate membership lists for each chamber, which do not indicate such splits:
https://www.ndlegis.gov/sites/default/files/resource/miscellaneous/2023senateroster.pdf
https://sdlegislature.gov/Legislators/Listing/68

@MiniCodeMonkey
Copy link
Contributor

@ballotpedia Thanks for double checking this! The sources I'm getting these from are:

North Dakota: https://ndlegis.gov/downloads/redistricting-2021/finalshape1282021.zip

South Dakota: The Find My Legislators 2021 adopted map: https://sdlegislature.gov/Legislators/Find (District 26A/B and 28A/B are visible).

I am not sure why there is mismatch with the legislator rooster.

@ballotpedia
Copy link
Contributor Author

@ballotpedia Thanks for double checking this! The sources I'm getting these from are:

North Dakota: https://ndlegis.gov/downloads/redistricting-2021/finalshape1282021.zip

South Dakota: The Find My Legislators 2021 adopted map: https://sdlegislature.gov/Legislators/Find (District 26A/B and 28A/B are visible).

I am not sure why there is mismatch with the legislator rooster.

Thank you -- sorry for the delay, but just an update that we are looking more closely into this

@ballotpedia
Copy link
Contributor Author

@ballotpedia Thanks for double checking this! The sources I'm getting these from are:

North Dakota: https://ndlegis.gov/downloads/redistricting-2021/finalshape1282021.zip

South Dakota: The Find My Legislators 2021 adopted map: https://sdlegislature.gov/Legislators/Find (District 26A/B and 28A/B are visible).

I am not sure why there is mismatch with the legislator rooster.

We have confirmed that only the lower chambers (House) for both of these states have these separate subdivisions.

@MiniCodeMonkey
Copy link
Contributor

@ballotpedia Thanks for confirming!

@jloutsenhizer
Copy link
Contributor

Overall I think this looks good, just have a few minor tweaks. Also, curious about the 'validTo' header, shouldn't it be 'validThrough' according to the docs @jloutsenhizer?

@nuttingd1 you're right about validThrough instead of validTo. I may have contributed to some of the incorrect use of validTo in other PRs. I'll look into rectifying that. @ballotpedia can you update this PR to make use of validThrough

Copy link
Contributor

@jloutsenhizer jloutsenhizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. @ballotpedia can you take a look into the issues raised by @nuttingd1

ocd-division/country:us/state:nc/sldu:28,North Carolina State Senate district 28,,
ocd-division/country:us/state:nc/sldu:29,North Carolina State Senate district 29,,
ocd-division/country:us/state:nc/sldu:30,North Carolina State Senate district 30,,
ocd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ballotpedia can you address this comment? I don't have a strong opinion either way

Comment on lines 779 to 780
ocd-division/country:us/state:ma/sldu:berkshire_hampshire_franklin_and_hampden,"Massachusetts Berkshire, Hampshire, Franklin & Hampden district",,2023-01-02
ocd-division/country:us/state:ma/sldu:berkshire_hampden_franklin_and_hampshire,"Massachusetts Berkshire, Hampden, Franklin, and Hampshire district",2023-01-03,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ballotpedia can you take a look into this?

@ballotpedia
Copy link
Contributor Author

Hi @jloutsenhizer , I have pushed a change that should take care of the issues mentioned above in the us_sldu.csv file.

  • Changed "validTo" to "validThrough"
  • Fixed the MA state senate validFrom and validThrough dates
  • Replaced underscores with hyphens in some VT state senate OCD IDs

I also ran the compile script and tests. Please let me know if there is anything else!

@nuttingd1
Copy link
Contributor

@ballotpedia can you also change the "validTo" header in the us_sldl.csv file to "validThrough" and run the compile script again?

@ballotpedia
Copy link
Contributor Author

@nuttingd1 done! How's it look now?

Copy link
Contributor

@nuttingd1 nuttingd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ballotpedia these changes look good to me!

Copy link

@stwlam stwlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but the person from our group who possibly had merge rights has left. @jloutsenhizer?

@jloutsenhizer jloutsenhizer merged commit ee6d507 into opencivicdata:master Feb 23, 2023
@jloutsenhizer
Copy link
Contributor

Thanks everyone for contributing to reviewing this. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants