TASK-6981 - Should not use same Solr timeout for reading and for indexing #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timeout for write operations, #TASK-6981
j-coll
requested changes
Sep 30, 2024
| @@ -157,14 +160,12 @@ public SearchConfiguration setTimeout(int timeout) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
Do not remove these methods.
Leave the methods deprecated, and just call to the static method
Configuration.reportUnusedField()
e.g.
There was a problem hiding this comment.
This will avoid failures in "old" configuration files that might be using the "rows" or "host" field.
There was a problem hiding this comment.
The ticket should have, in the "Communications" a message saying that this fields are removed.
j-coll
changed the title
… deleled methods to mark them as deprecated for backward-compatibility, #TASK-6981
j-coll
approved these changes
Oct 2, 2024
j-coll
changed the title
j-coll
previously approved these changes
Oct 4, 2024
j-coll
previously approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK-6981