Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-2242 #231

Open
wants to merge 37 commits into
base: release-2.4.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
50f98c4
Increase version to 2.0.2
imedina Sep 24, 2020
70a4aac
Merge branch 'release-2.0.0'
imedina Oct 6, 2020
b4ebb5c
Prepare release 2.0.3
imedina Oct 6, 2020
1e54b73
Merge branch 'release-2.0.0'
imedina Dec 31, 2020
bfe591b
Merge branch 'release-2.0.0'
imedina Mar 9, 2021
6bae883
Merge branch 'release-2.1.x'
imedina Jun 16, 2021
0380231
Merge branch 'release-2.1.x'
imedina Jul 24, 2021
5fd1edc
Prepare release 2.1.2
imedina Sep 30, 2021
fb33ef2
Merge branch 'release-2.1.x'
imedina Sep 30, 2021
1b47117
Merge branch 'release-2.2.x'
imedina Feb 11, 2022
a11dcb6
Merge branch 'release-2.2.x'
imedina Mar 16, 2022
55773a3
Merge branch 'release-2.2.x'
imedina Mar 25, 2022
22aac92
Merge branch 'release-2.3.x'
imedina May 17, 2022
1421c1a
Merge branch 'release-2.3.x'
imedina May 17, 2022
4f2a97e
Merge branch 'release-2.4.x'
imedina Jun 22, 2022
86856ba
Merge branch 'release-2.4.x'
imedina Aug 2, 2022
a946b26
Merge branch 'release-2.4.x'
imedina Aug 19, 2022
2926a2b
Merge branch 'release-2.4.x'
imedina Sep 7, 2022
1c484b9
cicd: remove report copy
imedina Sep 8, 2022
d4b422f
Merge branch 'release-2.4.x' into develop
imedina Sep 8, 2022
58a276a
Merge branch 'release-2.4.x' into develop
imedina Sep 8, 2022
068a9e0
pom: increase version to 2.5.0-SNAPSHOT
imedina Sep 8, 2022
f5017e4
Merge branch 'release-2.4.x'
imedina Sep 20, 2022
41671b3
Merge branch 'release-2.4.x'
juanfeSanahuja Oct 4, 2022
f5ab866
Merge branch 'release-2.4.x'
juanfeSanahuja Oct 7, 2022
eb50ed2
Merge branch 'release-2.4.x'
juanfeSanahuja Oct 19, 2022
ffa7595
Merge branch 'release-2.4.x'
juanfeSanahuja Oct 28, 2022
d998680
models: support a list of fitting scores for a given signatue, #TASK-…
jtarraga Nov 2, 2022
9366fea
models: update names, #TASK-2242, #TASK-2243
jtarraga Nov 9, 2022
83d1f64
models: add SignatureFittingScore, #TASK-2242, #TASK-2243
jtarraga Nov 9, 2022
ab6d56b
models: recover the old data field ID, TASK-2242, #TASK-2243
jtarraga Nov 9, 2022
c1a30ad
Fix version number
juanfeSanahuja Nov 11, 2022
52cef0d
Prepare release 2.5.0
juanfeSanahuja Nov 11, 2022
9995be8
Prepare new development version 2.5.1-SNAPSHOT
juanfeSanahuja Nov 11, 2022
ee52823
Prepare new development version
juanfeSanahuja Nov 11, 2022
8c9e4c3
pom:Update java-common-libs dependency version
juanfeSanahuja Nov 11, 2022
bfb1b80
Resolve conflicts, #TASK-2242
jtarraga Nov 22, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Install Samtools
run: sudo apt-get install samtools
- name: Run tests with Maven
run: mvn -T 2 clean install
run: mvn -T 2 clean install -DskipTests

deploy-maven:
uses: opencb/java-common-libs/.github/workflows/deploy-maven-repository-workflow.yml@develop
Expand Down
4 changes: 2 additions & 2 deletions biodata-external/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<artifactId>biodata</artifactId>
<groupId>org.opencb.biodata</groupId>
<version>2.4.9-SNAPSHOT</version>
<version>2.6.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down Expand Up @@ -80,4 +80,4 @@
</plugins>
</build>

</project>
</project>
2 changes: 1 addition & 1 deletion biodata-formats/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.opencb.biodata</groupId>
<artifactId>biodata</artifactId>
<version>2.4.9-SNAPSHOT</version>
<version>2.6.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion biodata-models/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.opencb.biodata</groupId>
<artifactId>biodata</artifactId>
<version>2.4.9-SNAPSHOT</version>
<version>2.6.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,19 @@ public class Signature {
description = FieldConstants.SIGNATURE_FILES_DESCRIPTION)
private List<String> files;

@Deprecated
@DataField(id = "fitting", indexed = true,
description = FieldConstants.SIGNATURE_SIGNATURE_FITTING_DESCRIPTION)
description = FieldConstants.SIGNATURE_SIGNATURE_FITTING_SCORE_DESCRIPTION)
private SignatureFitting fitting;

@DataField(id = "fittings", indexed = true,
description = FieldConstants.SIGNATURE_SIGNATURE_FITTING_SCORES_DESCRIPTION)
private List<SignatureFitting> fittings;

public Signature() {
}

@Deprecated
public Signature(String id, String description, ObjectMap query, String type, List<GenomeContextCount> counts, List<String> files,
SignatureFitting fitting) {
this.id = id;
Expand All @@ -69,6 +75,17 @@ public Signature(String id, String description, ObjectMap query, String type, Li
this.fitting = fitting;
}

public Signature(String id, String description, ObjectMap query, String type, List<GenomeContextCount> counts, List<String> files,
List<SignatureFitting> fittings) {
this.id = id;
this.description = description;
this.query = query;
this.type = type;
this.counts = counts;
this.files = files;
this.fittings = fittings;
}

@Override
public String toString() {
final StringBuilder sb = new StringBuilder("Signature{");
Expand All @@ -78,7 +95,7 @@ public String toString() {
sb.append(", type='").append(type).append('\'');
sb.append(", counts=").append(counts);
sb.append(", files=").append(files);
sb.append(", fitting=").append(fitting);
sb.append(", fittings=").append(fittings);
sb.append('}');
return sb.toString();
}
Expand Down Expand Up @@ -137,15 +154,26 @@ public Signature setFiles(List<String> files) {
return this;
}

@Deprecated
public SignatureFitting getFitting() {
return fitting;
}

@Deprecated
public Signature setFitting(SignatureFitting fitting) {
this.fitting = fitting;
return this;
}

public List<SignatureFitting> getFittings() {
return fittings;
}

public Signature setFittings(List<SignatureFitting> fittings) {
this.fittings = fittings;
return this;
}

public static class GenomeContextCount {

@DataField(id = "context", indexed = true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@

public class SignatureFitting {

@DataField(id = "id", indexed = true,
description = FieldConstants.SIGNATURE_FITTING_ID_DESCRIPTION)
private String id;

@DataField(id = "method", indexed = true,
description = FieldConstants.SIGNATURE_FITTING_METHOD_DESCRIPTION)
Expand All @@ -42,7 +45,7 @@ public class SignatureFitting {

@DataField(id = "scores", indexed = true, uncommentedClasses = {"Score"},
description = FieldConstants.SIGNATURE_FITTING_SCORES_DESCRIPTION)
private List<Score> scores;
private List<SignatureFittingScore> scores;

@Deprecated
@DataField(id = "coeff", indexed = true,
Expand All @@ -66,7 +69,8 @@ public SignatureFitting() {
}

@Deprecated
public SignatureFitting(String method, String signatureSource, String signatureVersion, List<Score> scores, double coeff, String file) {
public SignatureFitting(String method, String signatureSource, String signatureVersion, List<SignatureFittingScore> scores,
double coeff, String file) {
this.method = method;
this.signatureSource = signatureSource;
this.signatureVersion = signatureVersion;
Expand All @@ -75,8 +79,21 @@ public SignatureFitting(String method, String signatureSource, String signatureV
this.file = file;
}

public SignatureFitting(String method, String signatureSource, String signatureVersion, List<Score> scores, double coeff, String file,
List<String> files, ObjectMap params) {
@Deprecated
public SignatureFitting(String method, String signatureSource, String signatureVersion, List<SignatureFittingScore> scores,
double coeff, String file, List<String> files, ObjectMap params) {
this.method = method;
this.signatureSource = signatureSource;
this.signatureVersion = signatureVersion;
this.scores = scores;
this.coeff = coeff;
this.file = file;
this.files = files;
this.params = params;
}

public SignatureFitting(String id, String method, String signatureSource, String signatureVersion, List<SignatureFittingScore> scores,
double coeff, String file, List<String> files, ObjectMap params) {
this.method = method;
this.signatureSource = signatureSource;
this.signatureVersion = signatureVersion;
Expand All @@ -89,7 +106,8 @@ public SignatureFitting(String method, String signatureSource, String signatureV

@Override
public String toString() {
final StringBuilder sb = new StringBuilder("SignatureFitting{");
final StringBuilder sb = new StringBuilder("SignatureFittingScore{");
sb.append("id='").append(id).append('\'');
sb.append("method='").append(method).append('\'');
sb.append(", signatureSource='").append(signatureSource).append('\'');
sb.append(", signatureVersion='").append(signatureVersion).append('\'');
Expand All @@ -102,6 +120,15 @@ public String toString() {
return sb.toString();
}

public String getId() {
return id;
}

public SignatureFitting setId(String id) {
this.id = id;
return this;
}

public String getMethod() {
return method;
}
Expand Down Expand Up @@ -129,11 +156,11 @@ public SignatureFitting setSignatureVersion(String signatureVersion) {
return this;
}

public List<Score> getScores() {
public List<SignatureFittingScore> getScores() {
return scores;
}

public SignatureFitting setScores(List<Score> scores) {
public SignatureFitting setScores(List<SignatureFittingScore> scores) {
this.scores = scores;
return this;
}
Expand Down Expand Up @@ -173,45 +200,4 @@ public SignatureFitting setParams(ObjectMap params) {
this.params = params;
return this;
}

public static class Score {

private String signatureId;
private double value;

public Score() {
}

public Score(String signatureId, double value) {
this.signatureId = signatureId;
this.value = value;
}

@Override
public String toString() {
final StringBuilder sb = new StringBuilder("Score{");
sb.append("signatureId='").append(signatureId).append('\'');
sb.append(", value=").append(value);
sb.append('}');
return sb.toString();
}

public String getSignatureId() {
return signatureId;
}

public Score setSignatureId(String signatureId) {
this.signatureId = signatureId;
return this;
}

public double getValue() {
return value;
}

public Score setValue(double value) {
this.value = value;
return this;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
package org.opencb.biodata.models.clinical.qc;

public class SignatureFittingScore {

private String signatureId;
private double value;

public SignatureFittingScore() {
}

public SignatureFittingScore(String signatureId, double value) {
this.signatureId = signatureId;
this.value = value;
}

@Override
public String toString() {
final StringBuilder sb = new StringBuilder("SignatureFittingScore{");
sb.append("signatureId='").append(signatureId).append('\'');
sb.append(", value=").append(value);
sb.append('}');
return sb.toString();
}

public String getSignatureId() {
return signatureId;
}

public SignatureFittingScore setSignatureId(String signatureId) {
this.signatureId = signatureId;
return this;
}

public double getValue() {
return value;
}

public SignatureFittingScore setValue(double value) {
this.value = value;
return this;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@ public class FieldConstants {
public static final String SIGNATURE_TYPE_DESCRIPTION = "Signature type SNV, INDEL...";
public static final String SIGNATURE_COUNTS_DESCRIPTION = "List of GenomeContextCount";
public static final String SIGNATURE_FILES_DESCRIPTION = "List of files of signature";
public static final String SIGNATURE_SIGNATURE_FITTING_DESCRIPTION = "Signature fitting";
@Deprecated
public static final String SIGNATURE_SIGNATURE_FITTING_SCORE_DESCRIPTION = "Signature fitting";
public static final String SIGNATURE_SIGNATURE_FITTING_SCORES_DESCRIPTION = "List of signature fitting scores";
public static final String GENOME_CONTEXT_COUNT_CONTEXT_DESCRIPTION = "Genome context to count";
public static final String GENOME_CONTEXT_COUNT_TOTAL_DESCRIPTION = "Counted integer";
public static final String SIGNATURE_FITTING_ID_DESCRIPTION = "Signature fitting ID";
public static final String SIGNATURE_FITTING_METHOD_DESCRIPTION = "Method used to fit the signature";
public static final String SIGNATURE_FITTING_SOURCE_DESCRIPTION = "Source of the fitting signature";
public static final String SIGNATURE_FITTING_SIGNATURE_VERSION_DESCRIPTION = "Signature version of the fitting signature";
Expand Down
2 changes: 1 addition & 1 deletion biodata-tools/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>org.opencb.biodata</groupId>
<artifactId>biodata</artifactId>
<version>2.4.9-SNAPSHOT</version>
<version>2.6.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

<groupId>org.opencb.biodata</groupId>
<artifactId>biodata</artifactId>
<version>2.4.9-SNAPSHOT</version>
<version>2.6.0-SNAPSHOT</version>

<packaging>pom</packaging>

Expand All @@ -36,7 +36,7 @@
</modules>

<properties>
<java-common-libs.version>4.4.3-SNAPSHOT</java-common-libs.version>
<java-common-libs.version>4.6.0-SNAPSHOT</java-common-libs.version>
<collections.version>4.4</collections.version>
<avro.version>1.7.7</avro.version>
<protobuf.version>3.11.4</protobuf.version>
Expand Down