Bugfix for iterPages #940
Closed
Bugfix for iterPages #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During check of nextPage existence the field "has_more" might be used (gotten at body). Without it, iteration of, say all thread messages list brings to infinite loop.
|
Thanks for the PR @alexmakeev, can you share a reproduction script for the infinite loop issue? I'm surprised that could happen as I was under the impression the API would respond with an empty array when there aren't any entries left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During check of nextPage existence the field "has_more" might be used (gotten at body). Without it, iteration of, say all thread messages list brings to infinite loop.
Body field has unknown type (might be also detailed), so I used cast to "any" to skip linter/ts issues.
Changes being requested
Additional context & links