Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct findDoubleNewlineIndex to iterate to the second last pos… #927

Closed
wants to merge 1 commit into from
Closed

fix: Correct findDoubleNewlineIndex to iterate to the second last pos… #927

wants to merge 1 commit into from

Conversation

fEyebrow
Copy link

@fEyebrow fEyebrow commented Jul 10, 2024 •
edited
Loading

…ition

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

findDoubleNewlineIndex cannot find “\n\n” at the end, so correct findDoubleNewlineIndex to iterate to the second last position.

Additional context & links

@fEyebrow fEyebrow requested a review from a team as a code owner July 10, 2024 07:37
@RobertCraigie
Copy link
Collaborator

Thanks for the PR @fEyebrow, do you have an example script to showcase the issue with the current behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fEyebrow @RobertCraigie @kwhinnery-openai