Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to proposal help text #3243

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Corrections to proposal help text #3243

wants to merge 5 commits into from

Commits on May 31, 2023

  1. Fully test proposal help text 

    Covers:

  - initial form of new proposal
  - changed form of new proposal
  - initial form of existing proposal
  - changed form of existing proposal
    @AndrewKvalheim
    AndrewKvalheim committed May 31, 2023
    Configuration menu
    Copy the full SHA
    a67f328 View commit details
    Browse the repository at this point in the history

  2. Restore display of abstract length requirements 

    Accidentally lost during 81853d1

Resolves:

  1) Event as a participant not signed_in user submits proposal
     Failure/Error: expect(page).to have_text 'Abstracts must be between 0 and 500 words.'
       expected to find text "Abstracts must be between 0 and 500 words." in "…Abstracts must be between 0 and 250 words.…"
     # ./spec/features/proposals_spec.rb:94

250 is the initial value hard-coded in app/views/proposals/_form.html.haml
    @AndrewKvalheim
    AndrewKvalheim committed May 31, 2023
    Configuration menu
    Copy the full SHA
    48fddd2 View commit details
    Browse the repository at this point in the history

  3. Correct malformed Haml 

    Prior to this the view literally contained:

    You have used = @event.abstract_word_count words.
    @AndrewKvalheim
    AndrewKvalheim committed May 31, 2023
    Configuration menu
    Copy the full SHA
    16e637b View commit details
    Browse the repository at this point in the history

  4. Server-side render initial abstract length requirements

    @AndrewKvalheim
    AndrewKvalheim committed May 31, 2023
    Configuration menu
    Copy the full SHA
    63a83f1 View commit details
    Browse the repository at this point in the history

  5. Remove redundant client-side render 

    Incidentally resolves a JavaScript error introduced in openSUSE#3138 affecting
pages without the proposal form:

    Uncaught TypeError: text is undefined
      at word_count (app/assets/javascripts/osem.js:134)
    @AndrewKvalheim
    AndrewKvalheim committed May 31, 2023
    Configuration menu
    Copy the full SHA
    99c854f View commit details
    Browse the repository at this point in the history