Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored ConferencesController#calendar: separated calendar event c… #3101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactored ConferencesController#calendar: separated calendar event c… #3101

wants to merge 2 commits into from

Conversation

carlosdanielpohlod
Copy link

…reation into an specific service

Checklist

  • [ x ] I have read the Contribution & Best practices Guide.
  • [ x ] My branch is up-to-date with the upstream master branch.
  • [x ] The tests pass locally with my changes.
  • [ x] I have added tests that prove my fix is effective or that my feature works(if appropriate).
  • I have added necessary documentation (if appropriate).

Refactored conferences_controller#calendar: separated calendar event creation in a specific service. Also added a test to GET#calendar route.

Changes proposed in this pull request:

@carlosdanielpohlod carlosdanielpohlod mentioned this pull request Nov 11, 2022
Closed
2 tasks
@carlosdanielpohlod
Copy link
Author

@hennevogel (refactor of #3037 part I)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosdanielpohlod @carlospohlodcodeminer42