Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct time zone of API dates #3090

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

AndrewKvalheim
Copy link
Member

@AndrewKvalheim AndrewKvalheim commented Sep 28, 2022

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

Dates returned in the API have the time zone set to UTC instead of the conference time zone, resulting in an incorrect time.

Changes proposed in this pull request

Set the time zone to the conference time zone.

(Note that 6ce2e66 is the only commit unique to this pull request; the prior two are proposed in #3089.)

Concerns

I’ve kept this separate from #3089 since it might lead to deeper issues with time handling.

Effective API changes:

  - nil serializes to null, not empty string
  - dates serialize to IETF RFC 3339 with millisecond precision, not
    second precision surrounded by spaces
Prior to this change, the API returned incorrect dates in UTC instead of
the conference time zone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants