-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin ticketing #2306
base: master
Are you sure you want to change the base?
Admin ticketing #2306
Conversation
(cherry picked from commit ce0db3d7a736e7bcde480721986dbfb4a82aa083)
(cherry picked from commit aeeeb8e331673011842a35946a1bdba2611f901e)
37f24b6
to
3607854
Compare
Codecov Report
@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
+ Coverage 82.98% 83.03% +0.04%
==========================================
Files 145 145
Lines 4790 4804 +14
==========================================
+ Hits 3975 3989 +14
Misses 815 815
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
+ Coverage 82.98% 83.03% +0.04%
==========================================
Files 145 145
Lines 4790 4804 +14
==========================================
+ Hits 3975 3989 +14
Misses 815 815
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it, why do we need a ticket class for this? I have my doubts in this workflow. Can you please describe it in more detail? TIA
@bear454 can you please provide more details about this? 🙏 |
I don't know how to explain it much better, other than to rearrange the words a bit. As an administrator, I should be able to give a ticket to a user. |
Why? Why can't you just give them "normal" tickets? |
At LFNW, we give tickets to sponsored staff, booth staff, and speakers, which allows for provide them different material at checkin; we also use the tickets in our badge design. I'm sure you can understand that you wouldn't want the general public to be able to choose "speaker gift" ticket, for example. |
So the ticket is different to distinguish people at checkin, okay. Do you use 'free' tickets too? I would rather do this with |
No, we don't use 'free tickets' or 'registration tickets'. |
I could see creating a dynamic role for speakers, but I don't have any way to tie users to sponsored staff; we don't use the 'booth' feature. |
|
Well an admin can either 'give' them a 'special non visible' ticket, or they could assign them the role |
But if you need this as it is right now, we can merge it. It's just that we still run on |
I really like the way this feature works. Sponsers or companies having a booth often gets free tickets. |
I second this feature. This includes a solution for #2567. Hiding and showing tickets in general is useful, especially since we'll have early registrations and some temporary tickets. The conference we are running this summer will likely also gift tickets as a result of sponsorships or for a few community members. The fact that this workflow is explicit is a bonus, to me. The clarity around tickets that are normally X being counted as 0 is helpful, too, from an audit and budget perspective. |
before { sign_in admin } | ||
|
||
describe 'GET #index' do | ||
before { get :index, conference_id: conference } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now needs to be updated, but that's pretty quick.
Merged this in my fork and it's working well!
@@ -38,21 +38,50 @@ def update | |||
end | |||
end | |||
|
|||
def give | |||
ticket_purchase = @ticket.ticket_purchases.new(gift_ticket_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After using this for a conference, the workflow works pretty well! But, this leads to a somewhat weird scenario when a user has an unpaid ticket. Sometimes we want to give a sponsored ticket to someone who started to go through the purchase process and when this happens it requires console access to first delete their ticket. I wonder if it makes sense to have a "replace" option, or if an unpaid ticket exists to just update it to paid with a value of $0.
I'm now a couple days out from running the 4th event where we've successfully used this. One thing I just realized is that the #give method in this PR doesn't trigger the follow to create a physical ticket, and send a confirmation email. Both those seemed like useful things as we had a couple people that were confused. Simple fix: snap-cloud/snapcon@9ae89b5 (ignore accidentally removing the I will say, aside from the few people who attempt to buy a ticket then we need to give them one, this has worked quite well for my uses. Here's all of them:
I all these cases, I'm using registration tickets, since the common case is for someone to buy a reg ticket. It's quite nice that I and a couple others on our team can just drop in an email address to make sure someone is ready go. |
Allow admins to 'give' tickets to users, and create a class of tickets that can only be given by admins. This is a great way to handle providing material to sponsor staff.