Use autocomplete search for creator filter on requests index beta page #17201
+49
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krauselukas
changed the title
krauselukas
force-pushed
the
request_index/autocomplete_creator_filter
branch
from
802b025 to
f2e23ec
Compare
krauselukas
force-pushed
the
request_index/autocomplete_creator_filter
branch
from
f2e23ec to
50b69ec
Compare
|
Review app will appear here: http://obs-reviewlab.opensuse.org/krauselukas-request_indexautocomplete_creator_filter |
ncounter
reviewed
Dec 18, 2024
The accordion already indicates that this filter is for creators, no need to show this info twice.
ncounter
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
I just noticed a corner case behavior: the autocomplete does not prevent to choose a non-existing value. See the following:
It's a bit odd the user can select and filter by a non-existing value and see it checked in the list. I wonder if we should clear the filter value with existing values only or not.
It's rather a corner case I don't expect user to hit so much and it's harmless because the filter output is correct either way so, I'd say it is something that should not block the PR eventually. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.