feat: --stencil
now outputs default
& description
for attributes
#286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285
The stencil plugin now correctly populates the artificially created attribute for a field with
default
anddescription
from the detected member (if present), where it did not before:I investigated using handleDefaultValue per #285 (comment), but I don't think that function applies.
This is an artificially created attribute being injected into the class, and since handleDefaultValue is already ran to obtain the resultant values we see in the member already, we just need to copy values over to our artificial object.
I tested this locally on my custom stencil elements and it all seemed to work as expected. Members which did not have a default value nor description did not create extant fields in the produced attributes:
I also cleaned up some errant whitespace.