fix(static-analysis): fix for semgrep check failures #52
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olks and fallback
…olks and fallback
…olks and fallback
Release notes previewBelow is a preview of the release notes if your PR gets merged. 3.0.1 (2024-12-19)Bug Fixes
Miscellaneous
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have identified the semgrep checks failing for certain repos with non linear history as HEAD^ is unreliable in such cases, causing issues with merge commits and tags.
Solution:
Using git merge-base to dynamically determine the correct baseline commits. It identifies the common ancestor, ensuring semgrep compares the right changes. It adapts to different base branches(main, master, etc) and handles complex git histories. The solution is based of the recommendation from GHA error logs.