Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support build-contexts for docker build #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gopkri24
Copy link
Contributor

Description

Allow build-contexts during docker build

Changes

  • feat: support build-contexts for docker build

🚀 PR created with fotingo

@gopkri24 gopkri24 requested a review from a team as a code owner October 23, 2024 20:49
@gopkri24 gopkri24 force-pushed the c/support_build_contexts branch from 335163e to 42c8bb8 Compare October 23, 2024 21:33
build-contexts:
required: false
description: List of additional build contexts (e.g., name=path)
default: ""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure the empty string is a valid context for docker build? we could use the . as default if the empty string is not valid.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I think empty string will still work as we are giving the context . in the beginning

@gopkri24 gopkri24 force-pushed the c/support_build_contexts branch from 42c8bb8 to c2a1b67 Compare November 5, 2024 07:01
@gopkri24 gopkri24 force-pushed the c/support_build_contexts branch from c2a1b67 to efb9bb6 Compare November 5, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants