Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rxjava3 unit tests to Java #7924

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

kaibocai7
Copy link
Contributor

@kaibocai7 kaibocai7 commented Feb 28, 2023

Migrate rxjava3 unit tests from groovy to Java. #7195

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 28, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lonesomelilly / name: kc (d4ffdeb)

@kaibocai7 kaibocai7 marked this pull request as ready for review March 5, 2023 17:52
@kaibocai7 kaibocai7 requested a review from a team March 5, 2023 17:52
@kaibocai7
Copy link
Contributor Author

For the failed CI markdown-link-check seems due to the invalid links of Vert.x at supported-libraries.md

update testing logics for rxjava

update test instance level

migrate rxjava3 unit tests to java

sort traces for test - format code style

migrate rest of tests for rxjava3

format code style
@kaibocai7 kaibocai7 marked this pull request as draft April 4, 2023 12:11
fix more tests

fix comments - convert missed groovy tests
@kaibocai7 kaibocai7 marked this pull request as ready for review April 11, 2023 00:20
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaibocai7 !

@mateuszrzeszutek mateuszrzeszutek merged commit fd9ef74 into open-telemetry:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants