Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert http url connection test from groovy to java #7676

Merged
merged 2 commits into from
Feb 1, 2023
Merged

convert http url connection test from groovy to java #7676

merged 2 commits into from
Feb 1, 2023

Conversation

xiangtianyu
Copy link
Contributor

related to #7195

@xiangtianyu xiangtianyu requested a review from a team January 30, 2023 10:15
mateuszrzeszutek
mateuszrzeszutek reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @xiangtianyu !
I left a couple of minor comments.

.../src/test/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/StreamUtils.java Outdated Show resolved Hide resolved
...est/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/UrlConnectionTest.java Outdated Show resolved Hide resolved
...est/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/UrlConnectionTest.java Show resolved Hide resolved
...est/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/UrlConnectionTest.java Outdated Show resolved Hide resolved
...java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpUrlConnectionTest.java Outdated Show resolved Hide resolved
...java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpUrlConnectionTest.java Outdated Show resolved Hide resolved
@xiangtianyu
Copy link
Contributor Author

I fixed according to your suggestions and push a new. commit. @mateuszrzeszutek

mateuszrzeszutek
mateuszrzeszutek approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM 👍

@mateuszrzeszutek mateuszrzeszutek merged commit 6885c80 into open-telemetry:main Feb 1, 2023
@trask trask mentioned this pull request Feb 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangtianyu @mateuszrzeszutek