Apache HTTP Client 4.x: Fix content lengths #7467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6747
This is referencing the above issue for Apache Http Client 4.x
In version 1.18.0 requestLength and responseLengths were removed and instead in general
content-lengthheader is being used.The header doesn't really work in case of
chunkedencoding and for http client 5.x and even for content-length encoding the header is accessed from user-request when the header is actually appended in internal request.The approach followed in this MR is not really concerned about the user request
content-length, but mainly the bytes transferred in and out which is more or less closely equal to the content length only. We are intercepting the byte buffers, adding the bytes in / out of the buffer.We are storing these metrics with respect to the parent context in a virtual field for async client since there is so much disconnectivity. Suggestions are welcome for an improved approach. These metrics then are collected via an attributes extractor.