Replace runtime.jvm.gc.time/runtime.jvm.gc.count metrics with process.runtime.jvm.gc.duration histogram #6964
Conversation
|
I believe keeping the old GC time and count metrics (as non-monotonic counters) could be beneficial. This could be an option for those who want a quick look at these values without dealing with the complexities of histograms. |
|
On second thought, removing the old GC metrics would open a gap that could be filled by the new JMX Metric Insight (PR #6573) with optional JVM metrics grouped into the "jvm" platform. |
The view API allows you change the aggregation for instruments. If you don't need the histogram buckets, you ca configure the histogram to have a single bucket, which essentially transforms it into a sort of "summary" containing the sum, count, min, and max. You can look at just the sum and count to get the current gc time and count. |
...rary/src/test/java/io/opentelemetry/instrumentation/runtimemetrics/GarbageCollectorTest.java
Outdated
Show resolved
Hide resolved
...rary/src/test/java/io/opentelemetry/instrumentation/runtimemetrics/GarbageCollectorTest.java
Outdated
Show resolved
Hide resolved
In the 10/27 java sig we discussed that it would be valuable to enumerate the attributes reported for memory pool and gc metrics when different gcs are used. I've went ahead and added a readme for the runtime metrics which includes detailed information on the attributes reported. Note that I also have the same data for gc metrics added in #6964 and #6963, but will wait to add until those PRs are merged.
|
What are folks' thoughts on merging this before or after open-telemetry/opentelemetry-specification#2903? I'm slightly partial to waiting until the spec PR is merged to avoid churn for users. |
|
Spec PR has been merged and this is unblocked! |
trask
changed the title
|
Hey folks, after upgrading from io.opentelemetry.instrumentation/opentelemetry-runtime-metrics "1.16.0-alpha" --> io.opentelemetry.instrumentation/opentelemetry-runtime-metrics "1.24.0-alpha" I had a few issues with this metric:
|
|
hi @yorikya! can you open a fresh issue for this? |
|
Sure, thank you #8305 |
Replaces #6362.
I've reduced the attributes to only record the gc name and the action that was taken (i.e. I've removed the gc cause). If needed we can add the cause later, but for now this should be sufficient to determine total time spent in GC, and categorize time spent as stop the world or parallel.