Log4j2: add option to fill code attributes #12592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jeanbisutti in case you have a chance to review |
jeanbisutti
reviewed
Nov 8, 2024
| } | ||
| if (stackTraceClass == null) { | ||
| try { | ||
| stackTraceClass = Class.forName("org.apache.logging.log4j.core.impl.Log4jLogEvent"); |
There was a problem hiding this comment.
The stack trace class is not the same following the Log4j version? If so, could you please add comments to explain this?
It's perhaps the intent of the comment added at line 121? If so, could you please move this comment around the line 124?
| StackTraceElement source = sourceSupplier.get(); | ||
| if (source != null) { | ||
| String fileName = source.getFileName(); | ||
| if (fileName != null) { |
There was a problem hiding this comment.
(optional)
Suggested change
| if (fileName != null) { | |
| // file name can be null from the StackTraceElement Javadoc | |
| if (fileName != null) { |
There was a problem hiding this comment.
This is copy-pasted from the logback instrumentation. Apparently you are the author of it.
| Class<?> testClass, String methodName, AttributeAssertion... assertions) { | ||
| String selector = System.getProperty("Log4j2.contextSelector"); | ||
| boolean async = selector != null && selector.endsWith("AsyncLoggerContextSelector"); | ||
| if (async) { |
There was a problem hiding this comment.
I have not found the test using an asynch appender. Could you please give me a pointer?
The Readme should perhaps explain something about the asynch appenders?
There was a problem hiding this comment.
laurit
force-pushed
the
log4j2-code-attribute
branch
from
110c4b5
to
3eca7a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12540