stabilise spanNames #12487
stabilise spanNames #12487
Conversation
There was a problem hiding this comment.
It looks good! But I am curious about if there are any other documents or discussions to support this migration apart from quarkusio/quarkus#41521 (comment)? Because I am not sure whether other classes in instrumentation-api-incubator exist similar problem. @trask
...mentation-api/src/main/java/io/opentelemetry/instrumentation/api/semconv/util/SpanNames.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/util/SpanNames.java
Show resolved
Hide resolved
There was a problem hiding this comment.
@open-telemetry/java-instrumentation-approvers @jack-berg @brunobat any thoughts about committing to this as a stable API? thanks
| * This class has been stabilized and moved to {@link | ||
| * io.opentelemetry.instrumentation.api.semconv.util.SpanNames} | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Should have these methods delegate to the stable version to make sure the implementation doesn't drift.
| Map<String, String> spanNameCache = | ||
| spanNameCaches.computeIfAbsent(clazz, c -> new ConcurrentHashMap<>()); | ||
|
|
||
| // not using computeIfAbsent, because it would require a capturing (allocating) lambda |
There was a problem hiding this comment.
That shouldn't be the case if you use a method reference.
There was a problem hiding this comment.
I'm not sure how you would use a method reference here?
| import java.util.Map; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
|
|
||
| public final class SpanNames { |
resolve issue
move
SpanNamesfrominstrumentation-api-incubatortoinstrumentation-api