Convert play-mvc-2.4 groovy to java #12271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
commented
Sep 17, 2024
...4Test/java/io/opentelemetry/javaagent/instrumentation/play/v2_4/client/PlayWsClientTest.java
Outdated
Show resolved
Hide resolved
jaydeluca
reviewed
Sep 20, 2024
| @RegisterExtension | ||
| static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent(); | ||
|
|
||
| WSClient wsClient; |
There was a problem hiding this comment.
Suggested change
| WSClient wsClient; | |
| private static WSClient wsClient; |
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| wsClient = WS.newClient(-1); |
There was a problem hiding this comment.
The wsClient field uses @AutoCleanup in the groovy test. you could add
@RegisterExtension
static final AutoCleanupExtension autoCleanup = AutoCleanupExtension.create();
and then
Suggested change
| wsClient = WS.newClient(-1); | |
| wsClient = WS.newClient(-1); | |
| autoCleanup.deferCleanup(wsClient); |
| @RegisterExtension | ||
| static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent(); | ||
|
|
||
| WSClient wsClient; |
There was a problem hiding this comment.
Suggested change
| WSClient wsClient; | |
| private static WSClient wsClient; |
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| wsClient = WS.newClient(-1); |
There was a problem hiding this comment.
same comment here around adding the cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7195