Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert netty4.1 to java #12108

Merged
merged 16 commits into from
Sep 13, 2024
Merged

convert netty4.1 to java #12108

merged 16 commits into from
Sep 13, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Aug 26, 2024 •
edited
Loading

relate to #7195

@shalk shalk requested a review from a team August 26, 2024 07:30
@shalk shalk changed the title convert netty4.1 to java [WIP] convert netty4.1 to java Aug 26, 2024
@zeitlinger zeitlinger mentioned this pull request Aug 26, 2024
Open
@zeitlinger
Copy link
Member

no groovy files are deleted

@shalk
Copy link
Contributor Author

shalk commented Aug 26, 2024 •
edited
Loading

no groovy files are deleted

done

@shalk shalk changed the title [WIP] convert netty4.1 to java [DRAFT] convert netty4.1 to java Aug 26, 2024
@shalk shalk changed the title [DRAFT] convert netty4.1 to java convert netty4.1 to java Aug 27, 2024
jaydeluca
jaydeluca reviewed Sep 2, 2024
View reviewed changes
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java Outdated Show resolved Hide resolved
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java Outdated Show resolved Hide resolved
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java Outdated Show resolved Hide resolved
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java Outdated Show resolved Hide resolved
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java Outdated Show resolved Hide resolved
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java Show resolved Hide resolved
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java Show resolved Hide resolved
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java Show resolved Hide resolved
...src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/ChannelPipelineTest.java
channelPipeline.removeLast();

// http and instrumentation handlers will be remained;
assertThat(channelPipeline.first()).isEqualTo(handler);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, we're missing the assertions for the channelPipeline.toMap().size() in most of these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, add more assertions

...st/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/Netty41ConnectionSpanTest.java Outdated Show resolved Hide resolved
@trask trask merged commit c477eca into open-telemetry:main Sep 13, 2024
109 checks passed
@shalk shalk mentioned this pull request Oct 11, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverao steverao steverao left review comments

@jaydeluca jaydeluca jaydeluca approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
area:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shalk @zeitlinger @laurit @jaydeluca @steverao @trask @SylvainJuge