Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilise SpanNames #11693

Open
brunobat opened this issue Jun 28, 2024 · 1 comment · May be fixed by #12487
Open

Stabilise SpanNames #11693

brunobat opened this issue Jun 28, 2024 · 1 comment · May be fixed by #12487
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request

Comments

@brunobat
Copy link

Is your feature request related to a problem? Please describe.

This is a request to stabilise this class:
instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/util/SpanNames.java

Describe the solution you'd like

Span names should now be stable.

Describe alternatives you've considered

No response

Additional context

Idea comes from quarkusio/quarkus#41521 (comment)
@brunobat brunobat added enhancement New feature or request needs triage New issue that requires triage labels Jun 28, 2024
@brunobat brunobat mentioned this issue Jun 28, 2024
Merged
@trask
Copy link
Member

trask commented Oct 17, 2024

This seems reasonable to me. Just need to move it from instrumentation-api-incubator to instrumentation-api.

@trask trask added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome and removed needs triage New issue that requires triage labels Oct 17, 2024
@AlchemyDing AlchemyDing linked a pull request Oct 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stabilise spanNames AlchemyDing/opentelemetry-java-instrumentation
2 participants
@trask @brunobat