Apply suggestions from code review

Co-authored-by: Jay DeLuca <[email protected]>
open-telemetry · Aug 27, 2024 · fc2ab2c · fc2ab2c
1 parent 3ae01cb
commit fc2ab2c
Showing 1 changed file with 16 additions and 0 deletions.
diff --git a/...a/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/basic/SpringBatchTest.java b/...a/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/basic/SpringBatchTest.java
@@ -49,10 +49,12 @@ void shouldTraceTaskletJobStep() {
                 span ->
                     span.hasName("BatchJob taskletJob.step")
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(0)),
                 span ->
                     span.hasName("BatchJob taskletJob.step.Tasklet")
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(1))));
   }
 
@@ -70,6 +72,7 @@ void shouldHandleExceptionInTaskletJobStep() {
                 span ->
                     span.hasName("BatchJob taskletJob.step")
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(0)),
                 span ->
                     verifyException(
@@ -90,6 +93,7 @@ void shouldTraceChunkedItemsJob() {
               span ->
                   span.hasName("BatchJob itemsAndTaskletJob.itemStep.Chunk")
                       .hasKind(SpanKind.INTERNAL)
+                      .hasTotalAttributeCount(0)
                       .hasParent(trace.getSpan(1));
           trace.hasSpansSatisfyingExactly(
               span ->
@@ -99,17 +103,20 @@ void shouldTraceChunkedItemsJob() {
               span ->
                   span.hasName("BatchJob itemsAndTaskletJob.itemStep")
                       .hasKind(SpanKind.INTERNAL)
+                      .hasTotalAttributeCount(0)
                       .hasParent(trace.getSpan(0)),
               chunk,
               chunk,
               chunk,
               span ->
                   span.hasName("BatchJob itemsAndTaskletJob.taskletStep")
                       .hasKind(SpanKind.INTERNAL)
+                      .hasTotalAttributeCount(0)
                       .hasParent(trace.getSpan(0)),
               span ->
                   span.hasName("BatchJob itemsAndTaskletJob.taskletStep.Tasklet")
                       .hasKind(SpanKind.INTERNAL)
+                      .hasTotalAttributeCount(0)
                       .hasParent(trace.getSpan(5)));
         });
   }
@@ -128,18 +135,22 @@ void shouldTraceFlowJob() {
                 span ->
                     span.hasName("BatchJob flowJob.flowStep1")
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(0)),
                 span ->
                     span.hasName("BatchJob flowJob.flowStep1.Tasklet")
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(1)),
                 span ->
                     span.hasName("BatchJob flowJob.flowStep2")
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(0)),
                 span ->
                     span.hasName("BatchJob flowJob.flowStep2.Tasklet")
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(3))));
   }
 
@@ -167,20 +178,23 @@ void shouldTraceSplitFlowJob() {
                                 assertThat(spanData.getName())
                                     .matches("BatchJob splitJob.splitFlowStep[12].Tasklet"))
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(1)),
                 span ->
                     span.satisfies(
                             spanData ->
                                 assertThat(spanData.getName())
                                     .matches("BatchJob splitJob.splitFlowStep[12]"))
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(0)),
                 span ->
                     span.satisfies(
                             spanData ->
                                 assertThat(spanData.getName())
                                     .matches("BatchJob splitJob.splitFlowStep[12].Tasklet"))
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(3))));
   }
 
@@ -198,6 +212,7 @@ void shouldTraceJobWithDecision() {
                 span ->
                     span.hasName("BatchJob decisionJob.decisionStepStart")
                         .hasKind(SpanKind.INTERNAL)
+                        .hasTotalAttributeCount(0)
                         .hasParent(trace.getSpan(0)),
                 span ->
                     span.hasName("BatchJob decisionJob.decisionStepStart.Tasklet")
@@ -269,6 +284,7 @@ protected boolean hasPartitionManagerStep() {
   // should be moved to SpanDataAssert
   private static void verifyException(SpanDataAssert span, Throwable exception) {
     span.hasStatus(StatusData.error())
+      .hasTotalAttributeCount(0)
         .hasEventsSatisfying(
             events ->
                 assertThat(events.get(0))