pr review

open-telemetry · Sep 9, 2024 · fa5b22e · fa5b22e
1 parent 2b99db2
commit fa5b22e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.../io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/ItemLevelSpanTest.java b/.../io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/item/ItemLevelSpanTest.java
@@ -241,6 +241,8 @@ void shouldTraceAllItemOperationsOnAparallelItemsJob() {
                   span.hasName("BatchJob parallelItemsJob.parallelItemsStep.ItemWrite")
                       .hasKind(SpanKind.INTERNAL)
                       .hasParent(trace.getSpan(14)));
+
+          trace.hasSpansSatisfyingExactly(assertions);
         });
   }
 

diff --git a/...elemetry/javaagent/instrumentation/spring/batch/v3_0/item/JsrConfigItemLevelSpanTest.java b/...elemetry/javaagent/instrumentation/spring/batch/v3_0/item/JsrConfigItemLevelSpanTest.java
@@ -15,9 +15,4 @@ public class JsrConfigItemLevelSpanTest extends ItemLevelSpanTest {
   public JsrConfigItemLevelSpanTest() {
     super(runner);
   }
-
-  @Override
-  void shouldTraceAllItemOperationsOnAparallelItemsJob() {
-    // does not work - not sure why
-  }
 }