Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prettier work locally and integrate with node.js CI #146

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

shivam-sharma7
Copy link
Contributor

making sure prettier work locally and integrate with node.js CI

fixes: #134

@shivam-sharma7
Copy link
Contributor Author

shivam-sharma7 commented Jun 5, 2024

@Tsalmas-Anastasios @GeorgeApos This is crucial to keep formatting align with codebase. But for now I'm keeping it as draft till #101 merged.

@shivam-sharma7 shivam-sharma7 marked this pull request as draft June 6, 2024 02:30
@shivam-sharma7 shivam-sharma7 marked this pull request as ready for review June 22, 2024 06:27
@shivam-sharma7
Copy link
Contributor Author

@GeorgeApos @Tsalmas-Anastasios I have investigate that this is not causing any issue so safe to merge.

@GeorgeApos GeorgeApos merged commit ec39488 into open-source-uom:main Jun 22, 2024
1 check passed
@shivam-sharma7 shivam-sharma7 deleted the issue_134 branch June 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make sure prettier work locally and integrate with node.js CI
2 participants