Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Edges appending to only one instance of Svelvet container #513 #515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

turizspace
Copy link

Updated moveEdge function in Edge.svelte to correctly append the edge element to its respective Svelvet container based on containerId.

🔗 Linked issue

Resolves #513

🔗 Linked issue

Resolves #513

Description

  • Enhanced moveEdge function in Edge.svelte to ensure proper appending of edge elements to their respective Svelvet containers.
  • Previous implementation relied on static container selection, causing edges to append inconsistently across multiple Svelvet instances.
  • Refactored moveEdge to dynamically fetch the container using containerId, ensuring edges are appended to the correct instance based on context.
  • This change resolves visual inconsistencies and improves the reliability of edge rendering in complex Svelvet applications.

Checklist

  • I've followed the Contributing guidelines

  • I've titled my PR according to the Conventional Commits spec

  • I've linked an open issue

  • I've added tests that fail without this PR but pass with it

  • I've linted and tested my code

  • I've updated documentation (if appropriate)

…source-labs#513


    Updated moveEdge function in Edge.svelte to correctly append the edge element to its respective Svelvet container based on containerId.

🔗 Linked issue

Resolves open-source-labs#513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edges appending to only one instance of Svelvet container
1 participant