feat: add repo filtering to contributions tables on contributor profile #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdougie
approved these changes
Jun 20, 2024
|
Fixed the truncating with the issue comments on mobile |
jpmcb
reviewed
Jun 21, 2024
There was a problem hiding this comment.
3 things I noticed:
- There is no "feedback" or haptics to filtering on one of the repos. Its difficult to tell which is actually the one that is being selected on:
- The box on firefox still seems to break out to the right.
- It also seems to totally refresh the page when the "Issue comments" are selected.
It works on desktop, but not mobile. Fine to punt this work to a new PR to not distract from the original goal of this feature. 
|
|
Added some feedback when selected a repository, and tested the truncating issues on mobile on an Android phone in portrait and landscape. Will follow-up any additional changes in another PR. 
|
nickytonline
reviewed
Jul 3, 2024
nickytonline
approved these changes
Jul 3, 2024
components/organisms/ContributorProfileTab/contributor-profile-tab.tsx
Outdated
Show resolved
Hide resolved
|
Thanks! The CSS and repo selection issue is resolved |
open-sauced bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
## [2.42.0-beta.1](v2.41.1-beta.2...v2.42.0-beta.1) (2024-07-03) ### 🍕 Features * add repo filtering to contributions tables on contributor profile ([#3580](#3580)) ([a2e49ef](a2e49ef))
open-sauced bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
## [2.42.0](v2.41.0...v2.42.0) (2024-07-04) ### 🍕 Features * add repo filtering to contributions tables on contributor profile ([#3580](#3580)) ([a2e49ef](a2e49ef)) ### 🐛 Bug Fixes * lottery factor copy ([#3682](#3682)) ([baac008](baac008)) * now OSCR column is hidden if feature flag is not enabled for OSCR ([#3676](#3676)) ([061c590](061c590)) * now the contributor insights new/edit page fits in smaller screens ([#3679](#3679)) ([256af40](256af40))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Tickets & Documents
Closes #2024
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2024-06-18.at.3.02.15.PM.mov
Screen.Recording.2024-06-20.at.10.31.01.AM.mov
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?