Close #248: extraVolumes not working if either authz or `bootstra…

…pPolicies` are not enabled; Signed-off-by: Romain Caire <[email protected]>
open-policy-agent · Mar 12, 2024 · 81cf46e · 81cf46e
1 parent 05429a1
commit 81cf46e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/charts/opa-kube-mgmt/templates/deployment.yaml b/charts/opa-kube-mgmt/templates/deployment.yaml
@@ -252,9 +252,9 @@ spec:
               - key: {{ .Values.authz.mgmtToken.secretKey | default "mgmtToken" }}
                 path: mgmt-token
 {{- end }}
+{{- end }}
 {{- if .Values.extraVolumes }}
 {{ toYaml .Values.extraVolumes | indent 8}}
-{{- end }}
 {{- end }}
       affinity:
 {{ toYaml .Values.affinity | indent 8 }}

diff --git a/test/unit/kube-mgmt_args.yaml b/test/unit/kube-mgmt_args.yaml
@@ -45,3 +45,19 @@ tests:
       - contains:
           path: spec.template.spec.containers[1].args
           content: "--namespaces=*"
+  - it: should add extraVolumes if authz is disabled & no bootstrapPolicies are provided
+    set:
+      useHttps: false
+      authz:
+        enabled: false
+      extraVolumes:
+        - name: example-app-auth-config
+          secret:
+            secretName: example-app-auth-config
+    asserts:
+      - contains:
+          path: spec.template.spec.volumes
+          content: 
+            name: example-app-auth-config
+            secret:
+              secretName: example-app-auth-config